More scripting problems with Random Missions

[Teclis]

I'm finally trying to release Random Missions Morag Tong, but Morrowind seems to have problem with me getting it ready. I'm having trouble with one script which places dunmer MCA NPC in the cell if there aren't any already.
Here is the script, error is after Messagebox "TEST 1" line.

Code: Select all

Begin HV_RMMT_MakeTarget2


long MyRef
short state
short rand
short ChooseTarget
long MyString
short DoOnce
long IsValid

float Myx
float Myy
float Myz
long MyCell
;No dunmers in this cell so we are going to make our own.

ifx ( DoOnce )
else
       set rand to random, 36
       xFileRewind "MT_TargetCell"
       setx MyCell to xFileReadString "MT_TargetCell"
       Messagebox "TEST 1"
       xFileRewind "MCADunmerlist.RMMT"
       set Myx to HV_RMMT_Myx
       set Myy to HV_RMMT_Myy
       set Myz to HV_RMMT_Myz
       set DoOnce to 1
endif
      


       ifx ( rand )
               setx MyString to xFileReadString "MCADunmerlist.RMMT"
               set rand to ( rand - 1 )
       else
               Messagebox "Target Placed"
               setx Myref to xPlace MyString
               xsetRef Myref
               Startscript "HV_RM_MT_Targetscript"
               xPositionCell, Myx, Myy, Myz, 0, MyCell
               Myref->xAddspell "HV_RM_MT_Targetscript"
               set DoOnce to 0
               stopscript "HV_RMMT_MakeTarget2"
               return
       endif




end


[Jac Making my way back]

What error are you getting, Teclis?

[Teclis]

Sorry that I was unclear. Morrowind just crashes after that messagebox appears on the screen.

[Jac Making my way back]

Not being familiar with MWSE, I'm guessing it's this code snippet that's causing the problem:

Code: Select all

set Myx to HV_RMMT_Myx
  set Myy to HV_RMMT_Myy
  set Myz to HV_RMMT_Myz

It's likely that MW isn't able to read the coordinates from your file and is crashing because those floats are zero. I can give you some code that will randomly place NPCs in a cell, but it looks like you had specific places you wanted to place them. If that's the case, you may have to manually place those coordinates in the script for each NPC that's placed. Maybe Fligg or PK might have a better answer, though.

[Teclis]

Those globals are set in another script. But if you have script that randomly places NPCs I'd be glad to see it.

[Jac Making my way back]

It's from my lightning strike mod: the mod places an activator somewhere in the cell the player's in, which then places a ring somewhere else; but it can be reconfigured to place NPCs instead.

The activator placement script snippet (RanDist is a short):

Code: Select all

                       set RanDist to Random, 12
                               if ( RanDist == 0 )
                                       PlaceAtPC, "jac_lightningmarker", 0,100,1
                               elseif ( RanDist == 1 )
                                       PlaceAtPC, "jac_lightningmarker", 1,100,1
                               elseif ( RanDist == 2 )
                                       PlaceAtPC, "jac_lightningmarker", 2,100,1
                               elseif ( RanDist == 3 )
                                       PlaceAtPC, "jac_lightningmarker", 3,100,1
                               elseif ( RanDist == 4 )
                                       PlaceAtPC, "jac_lightningmarker", 0,500,1
                               elseif ( RanDist == 5 )
                                       PlaceAtPC, "jac_lightningmarker", 1,500,1
                               elseif ( RanDist == 6 )
                                       PlaceAtPC, "jac_lightningmarker", 2,500,1
                               elseif ( RanDist == 7 )
                                       PlaceAtPC, "jac_lightningmarker", 3,500,1
                               elseif ( RanDist == 8 )
                                       PlaceAtPC, "jac_lightningmarker", 0,1000,1
                               elseif ( RanDist == 9 )
                                       PlaceAtPC, "jac_lightningmarker", 1,1000,1
                               elseif ( RanDist == 10 )
                                       PlaceAtPC, "jac_lightningmarker", 2,1000,1
                               elseif ( RanDist == 11 )
                                       PlaceAtPC, "jac_lightningmarker", 3,1000,1
                               elseif ( RanDist == 12 )
                                       PlaceAtPC, "jac_lightningmarker", 1,1,1
                               endif

The activator script

Code: Select all

Begin jac_activatorscript

float timer
short doOnce
short RanDist

if ( doOnce == 1 )
       if ( timer < 3 )
               set timer to ( timer + GetSecondsPassed )
               return
       else
               setdelete 1
               set timer to 0
               set doOnce to 0
               return
       endif
endif

if ( jaclightningchance == 0 )
       Set doOnce to 1
       set RanDist to Random, 12
               if ( RanDist == 0 )
                       PlaceAtMe, "jac_lightningring", 0,100,1 ;this is the ring that causes the "strike".
               elseif ( RanDist == 1 )
                       PlaceAtMe, "jac_lightningring", 1,100,1
               elseif ( RanDist == 2 )
                       PlaceAtMe, "jac_lightningring", 2,100,1
               elseif ( RanDist == 3 )
                       PlaceAtMe, "jac_lightningring", 3,100,1
               elseif ( RanDist == 4 )
                       PlaceAtMe, "jac_lightningring", 0,500,1
               elseif ( RanDist == 5 )
                       PlaceAtMe, "jac_lightningring", 1,500,1
               elseif ( RanDist == 6 )
                       PlaceAtMe, "jac_lightningring", 2,500,1
               elseif ( RanDist == 7 )
                       PlaceAtMe, "jac_lightningring", 3,500,1
               elseif ( RanDist == 8 )
                       PlaceAtMe, "jac_lightningring", 0,1000,1
               elseif ( RanDist == 9 )
                       PlaceAtMe, "jac_lightningring", 1,1000,1
               elseif ( RanDist == 10 )
                       PlaceAtMe, "jac_lightningring", 2,1000,1
               elseif ( RanDist == 11 )
                       PlaceAtMe, "jac_lightningring", 3,1000,1
               elseif ( RanDist == 12 )
                       PlaceAtMe, "jac_lightningring", 1,1,1
               endif
else
       Set doOnce to 1
       set RanDist to Random, 12
               if ( RanDist == 0 )
                       PlaceAtMe, "jac_lightningmarker", 0,100,1
               elseif ( RanDist == 1 )
                       PlaceAtMe, "jac_lightningmarker", 1,100,1
               elseif ( RanDist == 2 )
                       PlaceAtMe, "jac_lightningmarker", 2,100,1
               elseif ( RanDist == 3 )
                       PlaceAtMe, "jac_lightningmarker", 3,100,1
               elseif ( RanDist == 4 )
                       PlaceAtMe, "jac_lightningmarker", 0,500,1
               elseif ( RanDist == 5 )
                       PlaceAtMe, "jac_lightningmarker", 1,500,1
               elseif ( RanDist == 6 )
                       PlaceAtMe, "jac_lightningmarker", 2,500,1
               elseif ( RanDist == 7 )
                       PlaceAtMe, "jac_lightningmarker", 3,500,1
               elseif ( RanDist == 8 )
                       PlaceAtMe, "jac_lightningmarker", 0,1000,1
               elseif ( RanDist == 9 )
                       PlaceAtMe, "jac_lightningmarker", 1,1000,1
               elseif ( RanDist == 10 )
                       PlaceAtMe, "jac_lightningmarker", 2,1000,1
               elseif ( RanDist == 11 )
                       PlaceAtMe, "jac_lightningmarker", 3,1000,1
               elseif ( RanDist == 12 )
                       PlaceAtMe, "jac_lightningmarker", 1,1,1
               endif
       set jaclightningchance to ( jaclightningchance - 1 )
endif

End

[Teclis]

That seems like a good way to place NPCs randomly. Do you mind if I modify that script and use it in my mod? I will of course credit you for it.

[Jac Making my way back]

Go right ahead. Fliggerty came up with the idea, so give him credit as well.

[Teclis]

I did a couple of tests and managed to pinpoint the error to

Code: Select all

  else
     Messagebox "Target Placed"
     setx Myref to xPlace MyString
     xsetRef Myref
     Startscript "HV_RM_MT_Targetscript"
     xPositionCell, Myx, Myy, Myz, 0, MyCell
     Myref->xAddspell "HV_RM_MT_Targetscript"
     set DoOnce to 0
     stopscript "HV_RMMT_MakeTarget2"
     return
  endif


Nothing seems to be wrong with part Jac pointed out though.

[Jac Making my way back]

Could it be that Myref isn't pulling a proper ref or even a ref at all?  

[Teclis]

Could be it. I'll try to add check for that and share the results.


E:

I modified the script and added the check to see if reference is other than 0. Still crashes when it's supposed to actually place the NPC.

Code: Select all

Begin HV_RMMT_MakeTarget2


long MyRef
short state
short rand
short ChooseTarget
long MyString
short DoOnce
short Count
short PlaceNPC

float Myx
float Myy
float Myz
long MyCell
;No dunmers in this cell so we are going to make our own.

ifx ( State )
else
       set rand to random, 36
       xFileRewind "MT_TargetCell"
       setx MyCell to xFileReadString "MT_TargetCell"
       Messagebox "TEST 1"
       xFileRewind "MCADunmerlist.RMMT"
       set Myx to HV_RMMT_Myx
       set Myy to HV_RMMT_Myy
       set Myz to HV_RMMT_Myz
       Messagebox "TEST 2"
       set State to 1
endif
      



ifx ( doonce )
       setx, MyString, to xFileReadString, "MCADunmerlist.RMMT"
       set count to ( count + 1 )
       if ( count < rand )
      Return
  endif

               ;if we get here, it means we have the name that corresponds with the random value
               set PlaceNPC to 1           
else
       xFileRewind "MCADunmerlist.RMMT"
       set count to 0
       set doonce to 1

endif


ifx ( PlaceNPC )
       ifx ( MyString )
               setx Myref to xPlace, MyString
               xSetref Myref
               SetPos, X, Myx
               xSetRef Myref
               SetPos, Y, Myy
               xSetRef, Myref
               SetPos, Z, Myz
               xSetRef Myref
               Startscript "HV_RM_MT_Targetscript"
               set state to 0
               set DoOnce to 0
               stopscript "HV_RMMT_MakeTarget2"
               return
       else
               set DoOnce to 0
               set rand to random, 36
              
endif
       endif



end


E2: Fliggerty said that xPlace can't be used with NPCs. I'll rewrite the script and use different commands.

[Jac Making my way back]

Is there a way to determine if it's retrieving the information it needs? Like say displaying that information via a message box.